Yet Another Script Problem (YASP)

Offhand, I'd say it's because you have an infinite loop without a Waitframe().

Saffith wrote:Offhand, I'd say it's because you have an infinite loop without a Waitframe().

Oh darn, I forgot that. XD I'm too used to item scripts. XD Thanks for telling me that. 😊

Edit: Well darn. That fixed the freezing problems, but... Now, whenever the "thing" is triggered, it goes to the wrong location. Okay, help me out here. I want to put a combo at an exact location without using FFCs (Because for some reason, doing it that way completely erases combo type...). I want to put Combo 3 at 96,80. How would I tell the script to look at x-96, y-80?

I'm not sure I see what you mean... Are you trying to change Screen->ComboD at a particular location? If that's it, it would be [font="Courier New"]Screen->ComboD[ComboAt(96, 80)]=3[/font].

Saffith wrote:I'm not sure I see what you mean... Are you trying to change Screen->ComboD at a particular location? If that's it, it would be [font="Courier New"]Screen->ComboD[ComboAt(96, 80)]=3[/font].

Oh. XD I've always wondered how I'd use ComboAt.... XD

Edit: It works, but there's a problem- The Combo Type refuses to work. 😞

What type of combo is it you're changing it to?

Saffith wrote:What type of combo is it you're changing it to?

Stairs. If I change it using a variable that isn't a loaded FFC, the combo type works. If I use a variable with a loaded FFC, the combo type doesn't work. It doesn't work here, either, and this is in build 240!

So Screen->ComboD[x]=3 works, but Screen->ComboD[x]=ffcPtr->Data doesn't? Is that what you're saying?

Saffith wrote:So Screen->ComboD[x]=3 works, but Screen->ComboD[x]=ffcPtr->Data doesn't? Is that what you're saying?

Huh? No, let me explain...

Before, I tried to make a variable be equal to "(96)&(80)", and that would put it at the wrong spot. When I did that, the stairs worked.

If I did "ffc varaible_here = Screen->LoadFFC(32)", I had to put the FFC's X and Y positions into one variables, so I'd do "variable_Here = (FFC->Y & 240)+(FFC->X>>4)", which is supposed to attach it to a specific combo location instead of by pixels (or so I was told). Then, when putting THAT variable into the ComboD line, it acts like I put the combo on Layer 1.... Meaning, the combo type gets completely erased!

Not even your version of doing it worked. 😞

Hm... Okay, what are you changing it from, then?
And when you say it doesn't work, you mean you can walk over the stairs and they just don't warp you anywhere?

Saffith wrote:Hm... Okay, what are you changing it from, then?
And when you say it doesn't work, you mean you can walk over the stairs and they just don't warp you anywhere?

What do you mean, what am I changing it from?

And yes, I can walk over the stairs and they won't warp me. Cancel Warp was NOT set on the screen's Tile Warps.

I mean, what sort of combo is there before you place the stairs?
Is the old combo type still in effect afterward?
And if you change it, does it make any difference?

I'm just trying to think of some reason this might be happening, and I haven't been able to reproduce it myself.

Edit: Wait, now I'm seeing it. Hm, that's definitely not right.

Edit again: Okay, try moving the FFC after you place the stairs. It seems like it might be blocking them somehow.
Yeah, something's definitely not working right here.

Saffith wrote:I mean, what sort of combo is there before you place the stairs?
Is the old combo type still in effect afterward?
And if you change it, does it make any difference?

I'm just trying to think of some reason this might be happening, and I haven't been able to reproduce it myself.

Edit: Wait, now I'm seeing it. Hm, that's definitely not right.

Edit again: Okay, try moving the FFC after you place the stairs. It seems like it might be blocking them somehow.
Yeah, something's definitely not working right here.

Okay, I'll try that. ...Yep, that was the problem. By the way, in the second FFC script I showed, for some reason, the check for the enemies isn't working right. It'll activate whether there are any enemies on the screen or not. =/ And by the way, I took out the ClearSprites() part because it deleted all enemies on-screen... (I forgot that enemies count as NPCs....)

Now that I think about it, it's probably supposed to block the stairs like that. Need it to do that sort of thing for moving platforms and such. Still, it's failing to get the FFC's position properly for some reason...
For the enemies thing, try using Trace() to check the value of Screen->NumNPCs(). Be sure it's what you think it is. Also, make sure it's actually being activated where you think, since it looks like there's more than one way it can happen.

Saffith wrote:Now that I think about it, it's probably supposed to block the stairs like that. Need it to do that sort of thing for moving platforms and such. Still, it's failing to get the FFC's position properly for some reason...
For the enemies thing, try using Trace() to check the value of Screen->NumNPCs(). Be sure it's what you think it is. Also, make sure it's actually being activated where you think, since it looks like there's more than one way it can happen.

Okay, I have NO clue how to work Trace(); ..... Mind helping me out?

Just give it a number and it'll record it in allegro.log when it executes.
So if you put [font="Courier New"]Trace(5);[/font] in your code, it'll put "5.0000" in allegro.log whenever it runs that line.
Since you can only trace numbers, be sure to use distinctive ones to mark what's what.

Saffith wrote:Just give it a number and it'll record it in allegro.log when it executes.
So if you put [font="Courier New"]Trace(5);[/font] in your code, it'll put "5.0000" in allegro.log whenever it runs that line.
Since you can only trace numbers, be sure to use distinctive ones to mark what's what.

You can't trace variables? Because I traced "ScrnNPCs" to find out what it's becoming, but.... Nothing. I can't seem to find it. 😞

If you see nothing at all, it'd be a good idea to trace some other things to be sure it's doing what you think it's doing.
If, for example, you have this:

if (condition)
{
  int ScrnNPCs = Screen->NumNPCs();
  Trace(ScrnNPCs);
  // ...
}
else
{
  // ...
}

if (condition)
{
  int ScrnNPCs = Screen->NumNPCs();
  Trace(1111);
  Trace(ScrnNPCs);
  // ...
}
else
{
  Trace(2222);
  // ...
}

Saffith wrote:If you see nothing at all, it'd be a good idea to trace some other things to be sure it's doing what you think it's doing.
If, for example, you have this:

if (condition)
{
  int ScrnNPCs = Screen->NumNPCs();
  Trace(ScrnNPCs);
  // ...
}
else
{
  // ...
}

... You might try this instead:

if (condition)
{
  int ScrnNPCs = Screen->NumNPCs();
  Trace(1111);
  Trace(ScrnNPCs);
  // ...
}
else
{
  Trace(2222);
  // ...
}

I tried doing another Trace (Using "2101", since I'm REALLY into AYB stuff now. XD), but... It never appeared in Allegro.log. Here's the output:

 SETV d2,0
 SETR d3,REFFFC
 PUSHR d3
 PUSHR d2
 SETR d4,SP
 SETV d2,0
 SETV d2,0.0001
 COMPAREV d2,0
 GOTOTRUE 133
 SETR d2,gd2
 PUSHR d2
 SETV d2,0
 POP d3
 COMPARER d2,d3
 GOTOTRUE 18
 SETV d2,0
 GOTO 19
 SETV d2,0.0001
 SETV d3,0
 COMPAREV d2,0
 GOTOTRUE 30
 SETV d2,1
 SETR gd1,d2
 PUSHR d4
 SETV d2,28
 PUSHR d2
 GOTO 137
 POP d4
 GOTO 126
 SETV d3,0
 SETR d2,gd2
 PUSHR d2
 SETV d2,1
 POP d3
 COMPARER d2,d3
 GOTOTRUE 39
 SETV d2,0
 GOTO 40
 SETV d2,0.0001
 SETV d3,0
 COMPAREV d2,0
 GOTOTRUE 92
 PUSHR d4
 SETV d2,49
 PUSHR d2
 SETR d2,gd0
 PUSHR d2
 GOTO 150
 POP d4
 SETR d6,d4
 ADDV d6,1
 STOREI d2,d6
 PUSHR d4
 SETV d2,59
 PUSHR d2
 SETV d2,2101
 PUSHR d2
 GOTO 140
 POP d4
 PUSHR d4
 SETV d2,68
 PUSHR d2
 SETR d6,d4
 ADDV d6,1
 LOADI d2,d6
 PUSHR d2
 GOTO 140
 POP d4
 SETR d6,d4
 ADDV d6,1
 LOADI d2,d6
 PUSHR d2
 SETV d2,0
 POP d3
 COMPARER d2,d3
 GOTOTRUE 79
 SETV d2,0
 GOTO 80
 SETV d2,0.0001
 SETV d3,0
 COMPAREV d2,0
 GOTOTRUE 90
 SETV d2,1
 SETR gd1,d2
 PUSHR d4
 SETV d2,89
 PUSHR d2
 GOTO 137
 POP d4
 SETV d2,0
 GOTO 125
 SETV d3,0
 SETR d2,gd2
 PUSHR d2
 SETV d2,3
 POP d3
 COMPARER d2,d3
 GOTOTRUE 101
 SETV d2,0
 GOTO 102
 SETV d2,0.0001
 SETV d3,0
 COMPAREV d2,0
 GOTOTRUE 124
 PUSHR d4
 SETV d2,113
 PUSHR d2
 SETR d2,gd0
 PUSHR d2
 SETR d2,gd4
 PUSHR d2
 GOTO 144
 POP d4
 COMPAREV d2,0
 GOTOTRUE 123
 SETV d2,1
 SETR gd1,d2
 PUSHR d4
 SETV d2,122
 PUSHR d2
 GOTO 137
 POP d4
 SETV d2,0
 SETV d2,0
 SETV d3,0
 SETV d3,0
 PUSHR d4
 SETV d2,131
 PUSHR d2
 GOTO 137
 POP d4
 GOTO 6
 SETV d2,0
 SETV d3,0
 POP d3
 QUIT
 WAITFRAME
 POP d3
 GOTOR d3
 POP d3
 TRACER d3
 POP d3
 GOTOR d3
 POP d0
 POP d3
 SETR d5,d3
 SETR d2,LINKITEMD
 POP d3
 GOTOR d3
 POP d3
 SETR d5,d3
 SETR d2,NPCCOUNT
 POP d3
 GOTOR d3

Please note that for some reason, the NPCCOUNT thing seems to happen AFTER a check for a certain inventory item in Link's inventory.... What's up with that?

Wait... Are you not running the script in the game before looking for the output? 'Cause you have to do that first.

Saffith wrote:Wait... Are you not running the script in the game before looking for the output? 'Cause you have to do that first.

Wait, I have to do that? Last time I tried that, I could've sworn there was no output whatsoever....

Edit: Nope, no output whatsoever. Would you like to see the allegro.log?

Sorry, been busy lately... 😛
Try putting a Trace() as the very first statement in run(), where it can't possibly miss it. If that doesn't give you something, it must be unable to write to the file properly for some reason.

Saffith wrote:Sorry, been busy lately... 😛
Try putting a Trace() as the very first statement in run(), where it can't possibly miss it. If that doesn't give you something, it must be unable to write to the file properly for some reason.

I think I got it to work once, but... It gave me a lot of numbers that made no sense....

Edit: By the way, do you happen to know how to correctly work the functions "Link->Warp" and "Link->PitWarp"? Every time I use the latter, nothing really happens when it's called. 😞 Take a look at this excerpt of code from my Harp of Ages script:

else if (Link->Item[ID2])
		{
			if (CurMap == 2 || CurMap == 4 || CurMap == 6 || CurMap == 8 || CurMap == 10)
			{
				Time = 0;
				Link->PitWarp(WrpDMap2, WrpScrn2);
				Quit();
			}
			else if (CurMap == 1 || CurMap == 3 || CurMap == 5 || CurMap == 7 || CurMap == 9)
			{
				Time = 1;
			}
		}

pikaguy900 wrote:I think I got it to work once, but... It gave me a lot of numbers that made no sense....

Edit: By the way, do you happen to know how to correctly work the functions "Link->Warp" and "Link->PitWarp"? Every time I use the latter, nothing really happens when it's called. 😞

Saffith wrote:How do you mean? They just weren't what you expected, or they literally couldn't have been generated by the script?

Hm. They should work just about the same way. If one works and the other doesn't, I'm inclined to think it's a bug.
I've been meaning to start looking at the compiler stuff. I suppose I'll look into it if DD doesn't beat me to it.

1: They were a lot of numbers that were usually things like "0.000000001" and then all these seemingly-random numbers placed to tell what that stupid number's value was....

2: Yeah, the code for the Tune of Currents part of the script is basically the same as the code for the Tune of Ages part. Neither work. Only the "Tune of Echoes" part works, because it changes a certain combo (And I also have to MOVE the FFC at its location because of the bug I was told about with FFCs. 😉 )... Or, maybe I'm using the wrong items.....

pikaguy900 wrote:1: They were a lot of numbers that were usually things like "0.000000001" and then all these seemingly-random numbers placed to tell what that stupid number's value was....

Saffith wrote:I'm still not quite certain I see what you mean... Can you give a specific example of this?

*sigh* Okay, the stuff is still in the allegro.log file...

Decrypting...okay.
Opening...okay.
Reading Header...okay.
Reading Rules...okay.
Reading Strings...okay.
Reading Doors...okay.
Reading DMaps...okay.
Reading Misc. Data...okay.
Reading Misc. Colors...okay.
Reading Game Icons...okay.
Reading Items...okay.
Reading Weapons...okay.
Reading Maps...okay.
Reading Combos...okay.
Reading Combo Aliases...okay.
Reading Color Data...okay.
Reading Tiles...okay.
Reading MIDIs...okay.
Reading Cheat Codes...okay.
Reading Init. Data...okay.
Reading Custom Guy Data...okay.
Reading Custom Link Sprite Data...okay.
Reading Custom Subscreen Data...okay.
Reading FF Script Data...okay.
Reading SFX Data...okay.
Done.
128 83 0
128 83
128 83 0
128 83
128 83 0
128 83
128 83 0
128 83
128 83 0
128 83
128 83 0
128 83
128 83 0
128 83
128 83 0
128 84
128 84 0
128 84
128 84 0
128 84
128 84 0
128 84
128 84 0
128 84
128 84 0
128 84
128 84 0
128 84
128 84 0
128 84
128 84 0
128 84
128 84 0
128 85
128 85 0
128 85
128 85 0
128 85
128 85 0
128 85
128 85 0
128 85
128 85 0
128 85
128 85 0
128 85
128 85 0
128 86
128 86 0
128 86
128 86 0
128 86
128 86 0
128 86
128 86 0
128 86
128 86 0
128 87
128 87 0
128 87
128 87 0
128 87
128 87 0
128 87
128 87 0
128 88
128 88 0
128 88
128 88 0
128 88
128 88 0
128 88
128 88 0
128 89
128 89 0
128 89
128 89 0
128 89
128 89 0
128 89
128 89 0
128 90
128 90 0
128 90
128 90 0
128 90
128 90 0
128 91
128 91 0
128 91
128 91 0
128 91
128 91 0
128 91
128 91 0
128 92
128 92 0

It's basically a lot of that with increasing numbers...

Edit: Which eventually start becoming random...

Ah, that? That's not from Trace(). It's just some debugging stuff in the current build.

Trace() will only print one number on each line, and it will always be to four decimal places.

Saffith wrote:Ah, that? That's not from Trace(). It's just some debugging stuff in the current build.

Trace() will only print one number on each line, and it will always be to four decimal places.

Well then, Trace() is broken, since it's not giving me ANYTHING.

Oh, what about my other problem? I tried changing the item required to use the "Tune of Currents" effect, but the effect STILL doesn't happen. 😞

Well then, Trace() is broken, since it's not giving me ANYTHING.

Oh, what about my other problem? I tried changing the item required to use the "Tune of Currents" effect, but the effect STILL doesn't happen. 😞