Read-only archive of the Armageddon Games Forums Archive (2000–2026) · About this archive
Armageddon Games Forums Archive

Filepack Fun, Itemdata

2 replies · 2,629 views · Started 07 June 2017

ZoriaRPG 07 Jun 2017, 02:01

I'm having more absolutely lovely fun with the filepack format not doing what I tell it to do.

This time, it;s with the itemdata struct, and aye, I did feed it specific version information, and I did bump V_ITEMS.

Does anyone want to have a look at this?

https://github.com/ZoriaRPG/ZeldaClassic/tree/ItemdataExp

The key files are:

qst.cpp, zfdefs.h, zq_class.cpp

The affected functions are[FONT=Courier New] readitems()[/FONT] and [FONT=Courier New]writeitems()[/FONT].

I commented out the sections that I was adding, and you can search for the string:

[FONT=Courier New] //! I need help with this.[/FONT]

to quickly find them.

The ZScript side of this is fine, and the jwin side seems to also be fine. I tried to create a debug build, but MSVC crashes outright when I do that.

Here is what happens when I try to build for debug.
[spoiler]


2>LINK : fatal error LNK1000: Internal error during IncrBuildImage
2>  Version 9.00.21022.08
2>  ExceptionCode            = C0000005
2>  ExceptionFlags           = 00000000
2>  ExceptionAddress         = 4C003FC0
2>  NumberParameters         = 00000002
2>  ExceptionInformation[ 0] = 00000008
2>  ExceptionInformation[ 1] = 4C003FC0
2>CONTEXT:
2>  Eax    = 4C003FC0  Esp    = 003AEE10
2>  Ebx    = 40008184  Ebp    = 003AEE3C
2>  Ecx    = 00DED670  Esi    = 4064510C
2>  Edx    = 003AEE2C  Edi    = 00EFD6C0
2>  Eip    = 4C003FC0  EFlags = 00010246
2>  SegCs  = 00000023  SegDs  = 0000002B
2>  SegSs  = 0000002B  SegEs  = 0000002B
2>  SegFs  = 00000053  SegGs  = 0000002B
2>  Dr0    = 00000000  Dr3    = 00000000
2>  Dr1    = 00000000  Dr6    = 00000000

[/spoiler]

Full MVSC log

DarkDragon 07 Jun 2017, 05:29

I gave you some tips on Skype, but I'll post here as well to help others:

1. You have to read and write data in exactly the same order in qst.cpp and zq_class.cpp.
2. You must use a consistent pair of read and write commands. You cannot write a 8-bit char and try to read it in as a 32-bit integer.

Please be extremely careful when making changes anywhere near the quest loading and saving code. Errors here cause quest corruption, which in the worse case goes undetected for several betas, and can cause quest authors to lose weeks or months of work.