[1112] Item scripts get invalid 'this' pointer

4 replies · 1,206 views · Started 21 December 2009

pkmnfrk 21 Dec 2009, 23:21

item script Suicide {
  void run() {
    if(!this->isValid()) Link->HP = 0;
  }
}

This causes Link to die when attached to an item's pickup script, and then subsequently picked up.

Gleeok 22 Dec 2009, 00:19

I'm not sure that non-ffcs are supposed to have an 'this' pointer.

..Why do you even need to check if the item you are currently using or obtaining is valid? If it wasn't, there would be no script running. :\

pkmnfrk 22 Dec 2009, 00:44

Well, the original script look(s/ed) like this:

item script FlexibleLootPickup {
  void run() {
    for(int i = 0; LootList != 0; i++) {
      if(LootList[i] == this->ID) {
        LootCount[i]++;
        return;
      }
    }
  }
}

The idea being that I just set the script and forget it.

In retrospect, though, I can understand why there [i]isn't a proper 'this' pointer, since the item doesn't actually exist any more by the time you pick it up! *shrug*

Gleeok 22 Dec 2009, 01:06

Ah! The lazy scripter syndrome.

You could use arguments for the item ID. Still very minimal work involved:

item script FlexibleLootPickup {
  void run(int id) {
    for(int i = 0; LootList[i] != 0; i++) {
      if(LootList[i] == id) {
        LootCount[i]++;
        return;
      }
    }
  }
}

pkmnfrk 22 Dec 2009, 01:19

Well, if I'm going to do that, I may as well just pass the pickup number!

item script PhatLewt {
	void run(int lewt) {
		LootCount[lewt]++;
	}
}

(copied from my script file with irrelevant stuff removed)