Set/getComboX Issues Remain

[ZoriaRPG]

Build 1799. It changed because accepting invalid input isn't a good idea in general, and it wasn't even consistent about what happened. Some invalid values would get adjusted to valid ones, some would do nothing, and an invalid screen number might even end up on a different map.

Build 1799, so, that was after 2.50.2 was released (build 1793, IIRC). I think what can happen because of this, is that if the user sets an invalid reference, and then tries to read it back, that in newer builds, it sets and returns different locations, that may have worked in the past.

I am also considering that something else may be at fault for what I am seeing in the reports, as one quest in particular, Panoply of Calatia, uses Game->Counter[] and Game->LKeys[] as if they were global variables; and apparently these are returning values in 2.53 that are off by one. @Mitsukara reported that values stored in these are returning one lower than the intended values stored.
@Saffith :

I agree with the change, and your logic here. The issue at hand, is that something changed that is affecting heavily scripted quests that reply on these functions, and I need to figure out precisely what the code needs to look like for the quests to run without breaking, and without maintaining issues in ZC that can cause ZC to crash.

Do you happen to recall if this change was part of this:

* Fixed incorrect screen calculation and possible crash in Game->SetComboSolid(). ( Saffith, 2015-12-19 19:41:38 )


Because, as far as I can tell, that was one of the things that was reverted, and that seems dreadful. I wish that there was a simpler solution to all of this, but it might just be easier and cleaner to revert all of these to the state that they were in, during 2.50.2, then add new functions that work properly to 2.54+ and to deprecate the use of these.

I also do not know what specifically you changed for this log entry:

* Fixed Game->Get/SetCombo* failing on maps greater than 1. ( Saffith, 2016-02-05 14:29:20 )

Are the old SVNs for the source still up anywhere, so that I can review changes that occurred prior to the code going up on GH?
@jman2050 might find that useful, as well.

If not, do you have snapshots of the 2.50.0, 2.50.1, and 2.50.2 release codebases on your systems?

[Saffith]

Do you happen to recall if this change was part of this:

* Fixed incorrect screen calculation and possible crash in Game->SetComboSolid(). ( Saffith, 2015-12-19 19:41:38 )

It was related to that. COMBOSDM worked differently than the others. It didn't zc_max things up to 0, it didn't subtract one from the map number, and it didn't validate the given map and screen numbers at all. The crash was because it didn't check whether the resulting screen was greater than the total number of screens. Fixing that didn't require changing the others, but the inconsistency annoyed me.

I also do not know what specifically you changed for this log entry:

* Fixed Game->Get/SetCombo* failing on maps greater than 1. ( Saffith, 2016-02-05 14:29:20 )

That was a mistake. Turned out I fixed a problem that hadn't made it into any released builds. Actually, it was an error in that change in 1799; it originally checked scr<MAPSCRS rather than sc<MAPSCRS.

Are the old SVNs for the source still up anywhere, so that I can review changes that occurred prior to the code going up on GH?

It's still up, yes. You'd have to talk to DD about access.

[ZoriaRPG]

It was related to that. COMBOSDM worked differently than the others. It didn't zc_max things up to 0, it didn't subtract one from the map number, and it didn't validate the given map and screen numbers at all. The crash was because it didn't check whether the resulting screen was greater than the total number of screens. Fixing that didn't require changing the others, but the inconsistency annoyed me.


That was a mistake. Turned out I fixed a problem that hadn't made it into any released builds. Actually, it was an error in that change in 1799; it originally checked scr<MAPSCRS rather than sc<MAPSCRS.


It's still up, yes. You'd have to talk to DD about access.

I spent ~6 hours working with these today. For whatever reason, quests that rely on the functions absolutely depend on them working precisely as they did in 2.50.2 and earlier. For a comparison, try to play ( this quest ) using Beta 10, and then try it in Beta 10 with these redacted to 2.50.2 code.

I produced > 35 builds today, just trying to sort this specific issue. It was quite ugly, and I would like to have a better resolution. but I already know the way this is going to roll.