User Tag List

Results 1 to 1 of 1

Thread: [zeditor] Crash to desktop when switching to combo pool page #85

  1. #1
    Octorok Asuna Yuuki Nagato's Avatar
    Join Date
    Jan 2024
    Posts
    491
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    vBActivity - Stats
    Points
    56
    Level
    2
    vBActivity - Bars
    Lv. Percent
    59.83%

    [zeditor] Crash to desktop when switching to combo pool page #85

    Steps to recreate:

    1. File->New
    2. Set drawing mode to 'Pool'
    3. rclick any combo pool in the combo lists
    4. Select 'Scroll to Page...' in the context menu
    5. Type '85' in the Number Picker prompt
    6. Press enter or click 'OK'

  2. #2
    Octorok Asuna Yuuki Nagato's Avatar
    Join Date
    Jan 2024
    Posts
    491
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    vBActivity - Stats
    Points
    56
    Level
    2
    vBActivity - Bars
    Lv. Percent
    59.83%
    This code snippet failed in zquest.cpp with a vector subscript out of range:

    Code:
    				for(int32_t j=0; j<num_combo_cols; ++j) //the actual panes
    				{
    					for(int32_t i=0; i<(comboaliaslist[j].w*comboaliaslist[j].h); i++)
    					{
    						int32_t cid=-1; int8_t cs=CSet;
    						combo_pool const& cp = combo_pools[combo_pool_listpos[j]+i];
    						
    						auto& list = comboaliaslist[j];
    						if(cp.get_w(cid,cs,0) && !combobuf[cid].tile)
    The last line above had a failed debug assertion in operator[] with cid == 1769172585

  3. #3
    Octorok Asuna Yuuki Nagato's Avatar
    Join Date
    Jan 2024
    Posts
    491
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    vBActivity - Stats
    Points
    56
    Level
    2
    vBActivity - Bars
    Lv. Percent
    59.83%
    combo_pool::get_w takes cid by reference, so it looks like that is how cid is getting set to such a huge value.

    combobuf has a size of 65280 at the time of crash.

  4. #4
    Octorok Asuna Yuuki Nagato's Avatar
    Join Date
    Jan 2024
    Posts
    491
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    vBActivity - Stats
    Points
    56
    Level
    2
    vBActivity - Bars
    Lv. Percent
    59.83%
    The number picker for alias pages is also affected.

  5. #5
    Octorok Asuna Yuuki Nagato's Avatar
    Join Date
    Jan 2024
    Posts
    491
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    vBActivity - Stats
    Points
    56
    Level
    2
    vBActivity - Bars
    Lv. Percent
    59.83%
    The combo pool being indexed is the 8192nd of the combo_pools array. MAXCOMBOPOOLS is #defined as 8192, so that is one past the last.

  6. #6
    Octorok Asuna Yuuki Nagato's Avatar
    Join Date
    Jan 2024
    Posts
    491
    Mentioned
    0 Post(s)
    Tagged
    0 Thread(s)
    vBActivity - Stats
    Points
    56
    Level
    2
    vBActivity - Bars
    Lv. Percent
    59.83%
    breaking out of the inner for loop averts the crash:

    Code:
    						int32_t cid=-1; int8_t cs=CSet;
    						int index = combo_pool_listpos[j]+i;
    						if (index == MAXCOMBOPOOLS) break;
    						combo_pool const& cp = combo_pools[index];

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
About us
Armageddon Games is a game development group founded in 1997. We are extremely passionate about our work and our inspirations are mostly drawn from games of the 8-bit and 16-bit era.
Social