Zelda Classic 2.53.0 ( Beta 10 )

[Saffith]

I (still) have a lot of issues with the additions to std.zh...

• std_*_2.54.zh shouldn't be included
• std_constants_shortcuts.zh shouldn't exist if it's going to be empty
• std_vars.zh has int GlobalBugger[214747]
• Out of date comments ("//!...and will be fixed in 2.50.3.")
• Incorrect comments ("//dir+DIR_IGNORESHIELD: Prevents blocking by enemy shields.")
• NPCA*_ constants appear to be appropriate only for walking enemies
• Constants meant for features that don't exist here (WARPFX_*)
• Constants with no clear purpose (ERR_RETURN)
• Constants that are simply wrong (DEG_DIR_* and RAD_DIR* are flipped vertically)
• Similarly, all of the new direction to angle functions are wrong
• Typos (SFW_SENDDIRECT should be SFW_SENSDIRECT)
• Aside from dubious usefulness, the CHAR_ constants in particular have several issues:
  
  • ASCII values 1-31 are never meaningful in ZC, so why include them?
  • The characters represented by values 127 and up vary depending on the font, so the constants are misleading
  • Incorrect, or at least non-standard, terms
  • Lots of typos and spelling errors

I can get a more thorough list together, but I don't know what exactly the plan is here.

[DarkDragon]

@ZoriaRPG since you are currently most involved with the ZScript changes in 2.50.x, could you please address Saffith's reported issues?

[Gleeok]

@ZoriaRPG since you are currently most involved with the ZScript changes in 2.50.x, could you please address Saffith's reported issues?

I just saw this message from him:

I am again unable to access AGN
Same issue as before:
Your connection to this server has been blocked in this server's firewall.

IIRC wasn't this a temporary issue that fixed itself last time? I'm not sure, but here it is.


[edit] Just sticking this here since I'm not sure if it got fixed yet or not (I'm using a 2.50.2-ish ZQ build for this quest right now).

Side Warp-> set up to 'A'; then goto Screen data-> timed warp ticks = 90; then check the random warp box and ZQuest crashes.