Strange Compiler Error

[ZoriaRPG]

Link->Invisible needs it, too. I think that's the only other one.
Shouldn't this be corrected in the repo before it's marked as fixed?

It is corrected in the stuff that I have staged to merge. DarkDragon asked not to make any new commits until he finishes his internal changes. I can put the 2.50.2.1 source up separately if you want, but I do not have access to dump it to GH/AGN.

Here is the revision for this fix for master:

https://github.com/ZoriaRPG/ZeldaCla...eturn?expand=1

I thought that marking a bug as 'sick' was the appropriate middle-ground between implementing the fix, and verifying that it was fixed in use?

Here is the 2.50.2.1 code: https://github.com/ZoriaRPG/ZeldaClassic_2.53

Edit: I re-applied the changes to the 2.50.x branch:
https://github.com/ArmageddonGames/Z...oriaRPG:2.50.x

Let's hope that I did not overlook anything, and that this compiles properly.

It does seem odd to me that this has never turned up before, but I figured it would be an easy fix.

I'm guessing that the setters were all correct, otherwise they'd have complained long hence. There's no telling why the getters were wrong.

Aye. The setters are fine, and as I said, i suspect it is because the syntax if ( Link->CollDetection ) or if ( Link->Invisible ) is cleaner, or easier to type, and read; as compared to if ( foo == true ) . It is also less error-prone, as you cannot have an assign here where you intend a compare, when doing a simple boolean evaluation, so fewer people use == true in these cases.

Similarly, most users will do if ( !foo ) rather than if ( foo == false ). I would still have expected it to be reported before, but the userbase is clearly not reporting issues when they should, and they try to find hacks, or workarounds to the, rather than alerting us fix them.

Internally all of these values are integers. Only the ZScript parser distinguishes between float, and bool; or other types.