User Tag List

Results 1 to 8 of 8

Thread: VenRob as Proper Dev

  1. #1
    The Timelord
    QDB Manager
    ZC Developer
    ZoriaRPG's Avatar
    Join Date
    Oct 2006
    Location
    Prydon Academy
    Posts
    1,339
    Mentioned
    109 Post(s)
    Tagged
    1 Thread(s)
    vBActivity - Stats
    Points
    4,460
    Level
    21
    vBActivity - Bars
    Lv. Percent
    8.74%

    VenRob as Proper Dev

    @Grayswandir

    @Gleeok

    @jman2050

    Given how helpful Rob has been, that he has become familiar-enough with the source, git, and the tools to work on ZC to the extent of adding new features without aid, and his willingness to do builds, I'd like to elevate him to full dev status.

    He seems to have gotten the rules on doing merges in his head, and is now being more careful, so I think that won't be an issue--although I won't be giving him ownership on the repo, just merge access.

    What are your thoughts here?

    (Given that jman is pseudo-retired, if he doesn't respond, that's fine.)

    I'm pretty sure that ultimately, it's my call here, but I want to gather your thoughts on this, before I do anything.

  2. #2
    OBEY GOVERNMENT GOD ZC Developer
    Gleeok's Avatar
    Join Date
    Apr 2007
    Posts
    4,779
    Mentioned
    256 Post(s)
    Tagged
    10 Thread(s)
    vBActivity - Stats
    Points
    12,682
    Level
    32
    vBActivity - Bars
    Lv. Percent
    96.64%
    I'm glad someone new is interested in working on ZC. That is good news! :)

    Yeah, I've noticed he's been working on various things recently and that you were helping him along, although I haven't looked at any of the commits; I guess I'll do that right now.

    ...Well that didn't take long.

    The last commit was a two-line fix:
    Code:
    	- //m->initd[(ri->d[0]/10000)][(ri->d[1]/10000)] = (value/10000);
    	+  m->initd[(ri->d[0]/10000) - 1][(ri->d[1]/10000)] = value;
    Correct me if I'm wrong, but that looks like overflow to me. ...or did I just get (un)lucky with my timing?
    Last edited by Gleeok; 11-01-2018 at 06:43 AM.
    "Protocols of the Learned Elders of Zion" (British Royal Institute, 1906)
    "The International Jew: The World's Foremost Problem" �Henry Ford
    "Dope Inc. - Britain Opium War Against The U.S." (LaRouche; Konstandinos Kalimtgis; David Goldman; Jeffrey Stienberg, 1978)
    "Fundamental Laws: A Report of the 68th Convocation of the Rose Cross Order" 1916
    "War is a Racket" �Major General Smedley Butler
    "The Secret Destiny of America" �Manly P. Hall
    "A Strategy for Israel in the Nineteen Eighties" Oded Yinon (English Translation)
    The WWI Conspiracy: Part 1 - Part 2 - Part 3 "A New World Order"
    The War You Don't See
    Psywar

    �The modern theory of the perpetuation of debt has drenched the earth with blood, and crushed its inhabitants under burdens ever accumulating.� �Thomas Jefferson
    �It is well enough that the people of the nation do not understand our banking and monetary system for, if they did, I believe there would be a revolution before tomorrow morning.� �Henry Ford
    �Man will ultimately be governed by God or by tyrants.� �Benjamin Franklin

    This post contains the official Gleeok� seal of approval. Look for these and other posts in an area near you.

  3. #3
    The Timelord
    QDB Manager
    ZC Developer
    ZoriaRPG's Avatar
    Join Date
    Oct 2006
    Location
    Prydon Academy
    Posts
    1,339
    Mentioned
    109 Post(s)
    Tagged
    1 Thread(s)
    vBActivity - Stats
    Points
    4,460
    Level
    21
    vBActivity - Bars
    Lv. Percent
    8.74%
    Quote Originally Posted by Gleeok View Post
    I'm glad someone new is interested in working on ZC. That is good news! :)

    Yeah, I've noticed he's been working on various things recently and that you were helping him along, although I haven't looked at any of the commits; I guess I'll do that right now.

    ...Well that didn't take long.

    The last commit was a two-line fix:
    Code:
    	- //m->initd[(ri->d[0]/10000)][(ri->d[1]/10000)] = (value/10000);
    	+  m->initd[(ri->d[0]/10000) - 1][(ri->d[1]/10000)] = value;
    Correct me if I'm wrong, but that looks like overflow to me. ...or did I just get (un)lucky with my timing?
    No overflow? That's an InitD function. The value was being divided and multiplied when it should not have been, and the ffc index wasn't properly offset. Both my fault, and I sent him a text file with the patch, that he committed while my laptop was in surgery.

    Both InitD and MiscD are always a raw values, and I forgot that here, when I wrote 300 ZScript commands all at once. All refinfo registers are also always raw.

    Off-topic, but my plans this week are to finish uop bitmaps, fix script drawing stuff--cset2 related-- and to ffix some other critical bugs. I'm going to start on npc script stuff soon, as well. I need to get bitmap->Blit(dest,args) and some basic draw commands in for bitmaps, so that I can test if bitmap->Create(h,w) works as I intend.

    I finally got that in there in the most straightforward manner possible.

    Anyway, he's doing a good job, seems dedicated, and his outpit is constructive.
    Last edited by ZoriaRPG; 11-02-2018 at 09:52 AM.

  4. #4
    OBEY GOVERNMENT GOD ZC Developer
    Gleeok's Avatar
    Join Date
    Apr 2007
    Posts
    4,779
    Mentioned
    256 Post(s)
    Tagged
    10 Thread(s)
    vBActivity - Stats
    Points
    12,682
    Level
    32
    vBActivity - Bars
    Lv. Percent
    96.64%
    Well, maybe I am hallucinating or something, but what's to stop refInfo.d[] from being less than 1...?

    m->initd[(ri->d[0]/10000) - 1][(ri->d[1]/10000)] = value;

    Is this valid?
    "Protocols of the Learned Elders of Zion" (British Royal Institute, 1906)
    "The International Jew: The World's Foremost Problem" �Henry Ford
    "Dope Inc. - Britain Opium War Against The U.S." (LaRouche; Konstandinos Kalimtgis; David Goldman; Jeffrey Stienberg, 1978)
    "Fundamental Laws: A Report of the 68th Convocation of the Rose Cross Order" 1916
    "War is a Racket" �Major General Smedley Butler
    "The Secret Destiny of America" �Manly P. Hall
    "A Strategy for Israel in the Nineteen Eighties" Oded Yinon (English Translation)
    The WWI Conspiracy: Part 1 - Part 2 - Part 3 "A New World Order"
    The War You Don't See
    Psywar

    �The modern theory of the perpetuation of debt has drenched the earth with blood, and crushed its inhabitants under burdens ever accumulating.� �Thomas Jefferson
    �It is well enough that the people of the nation do not understand our banking and monetary system for, if they did, I believe there would be a revolution before tomorrow morning.� �Henry Ford
    �Man will ultimately be governed by God or by tyrants.� �Benjamin Franklin

    This post contains the official Gleeok� seal of approval. Look for these and other posts in an area near you.

  5. #5
    The Timelord
    QDB Manager
    ZC Developer
    ZoriaRPG's Avatar
    Join Date
    Oct 2006
    Location
    Prydon Academy
    Posts
    1,339
    Mentioned
    109 Post(s)
    Tagged
    1 Thread(s)
    vBActivity - Stats
    Points
    4,460
    Level
    21
    vBActivity - Bars
    Lv. Percent
    8.74%
    Quote Originally Posted by Gleeok View Post
    Well, maybe I am hallucinating or something, but what's to stop refInfo.d[] from being less than 1...?

    m->initd[(ri->d[0]/10000) - 1][(ri->d[1]/10000)] = value;

    Is this valid?
    Oh dear, it looks like that one is indeed missing a sanity bound. It should have two, in fact.

    Specifically, it needs this:

    Code:
    int ffid = (ri->d[0]/10000)-1;
    int indx = ri->d[1]/10000;
    
    if ( ffid < 0 || ffid > 31 ) 
    {
        Z_scripterrlog("Invalid FFC id passed to mapdata->FFCInitD[]: %d",ffid); 
    }
    else if ( indx < 0 || indx > 7 )
    {
        Z_scripterrlog("Invalid InitD[] index passed to mapdata->FFCInitD[]: %d",indx);
    }
    else
    { 
        m->initd[ffid][(ri->d[indx] = value;
    }
    One of these days I'll add some more boundscheck inline functions for this sort of thing.
    Last edited by ZoriaRPG; 11-03-2018 at 01:53 PM.

  6. #6
    OBEY GOVERNMENT GOD ZC Developer
    Gleeok's Avatar
    Join Date
    Apr 2007
    Posts
    4,779
    Mentioned
    256 Post(s)
    Tagged
    10 Thread(s)
    vBActivity - Stats
    Points
    12,682
    Level
    32
    vBActivity - Bars
    Lv. Percent
    96.64%
    Here's a little trick for bounds checks:

    Code:
    if(a < 0 || a >= MAX) { error }; //instead of this,
    
    if((unsigned)a >= MAX) //compile time optimization
    Back on topic, I was really only looking at his code for safety and bugs, which is basically the main prerequisite for write access.
    "Protocols of the Learned Elders of Zion" (British Royal Institute, 1906)
    "The International Jew: The World's Foremost Problem" �Henry Ford
    "Dope Inc. - Britain Opium War Against The U.S." (LaRouche; Konstandinos Kalimtgis; David Goldman; Jeffrey Stienberg, 1978)
    "Fundamental Laws: A Report of the 68th Convocation of the Rose Cross Order" 1916
    "War is a Racket" �Major General Smedley Butler
    "The Secret Destiny of America" �Manly P. Hall
    "A Strategy for Israel in the Nineteen Eighties" Oded Yinon (English Translation)
    The WWI Conspiracy: Part 1 - Part 2 - Part 3 "A New World Order"
    The War You Don't See
    Psywar

    �The modern theory of the perpetuation of debt has drenched the earth with blood, and crushed its inhabitants under burdens ever accumulating.� �Thomas Jefferson
    �It is well enough that the people of the nation do not understand our banking and monetary system for, if they did, I believe there would be a revolution before tomorrow morning.� �Henry Ford
    �Man will ultimately be governed by God or by tyrants.� �Benjamin Franklin

    This post contains the official Gleeok� seal of approval. Look for these and other posts in an area near you.

  7. #7
    The Timelord
    QDB Manager
    ZC Developer
    ZoriaRPG's Avatar
    Join Date
    Oct 2006
    Location
    Prydon Academy
    Posts
    1,339
    Mentioned
    109 Post(s)
    Tagged
    1 Thread(s)
    vBActivity - Stats
    Points
    4,460
    Level
    21
    vBActivity - Bars
    Lv. Percent
    8.74%
    Quote Originally Posted by Gleeok View Post
    Here's a little trick for bounds checks:

    Code:
    if(a < 0 || a >= MAX) { error }; //instead of this,
    
    if((unsigned)a >= MAX) //compile time optimization
    Back on topic, I was really only looking at his code for safety and bugs, which is basically the main prerequisite for write access.

    Good point, and fixed. Anyway, this was my oversight. Rob has been helping me test, and prove some of the new stuff, and informing me of any issues. He applied the patch at my instruction, and I forgot to include the same BC as with the other related instructions. (These two are special, as they're commands, not variables.)

    https://github.com/ArmageddonGames/Z...719abba2cd9489
    Last edited by ZoriaRPG; 11-05-2018 at 03:19 PM.

  8. #8
    OBEY GOVERNMENT GOD ZC Developer
    Gleeok's Avatar
    Join Date
    Apr 2007
    Posts
    4,779
    Mentioned
    256 Post(s)
    Tagged
    10 Thread(s)
    vBActivity - Stats
    Points
    12,682
    Level
    32
    vBActivity - Bars
    Lv. Percent
    96.64%
    Aha, got you red handed!!!

    So yeah, his stuff looks pretty good. Go ahead and give him write access. Sounds like a plan.
    "Protocols of the Learned Elders of Zion" (British Royal Institute, 1906)
    "The International Jew: The World's Foremost Problem" �Henry Ford
    "Dope Inc. - Britain Opium War Against The U.S." (LaRouche; Konstandinos Kalimtgis; David Goldman; Jeffrey Stienberg, 1978)
    "Fundamental Laws: A Report of the 68th Convocation of the Rose Cross Order" 1916
    "War is a Racket" �Major General Smedley Butler
    "The Secret Destiny of America" �Manly P. Hall
    "A Strategy for Israel in the Nineteen Eighties" Oded Yinon (English Translation)
    The WWI Conspiracy: Part 1 - Part 2 - Part 3 "A New World Order"
    The War You Don't See
    Psywar

    �The modern theory of the perpetuation of debt has drenched the earth with blood, and crushed its inhabitants under burdens ever accumulating.� �Thomas Jefferson
    �It is well enough that the people of the nation do not understand our banking and monetary system for, if they did, I believe there would be a revolution before tomorrow morning.� �Henry Ford
    �Man will ultimately be governed by God or by tyrants.� �Benjamin Franklin

    This post contains the official Gleeok� seal of approval. Look for these and other posts in an area near you.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
About us
Armageddon Games is a game development group founded in 1997. We are extremely passionate about our work and our inspirations are mostly drawn from games of the 8-bit and 16-bit era.
Social