User Tag List

Page 1 of 2 1 2 LastLast
Results 1 to 10 of 13

Thread: 2.53 Fixes -> Master : Need a Period of Suspended Pushes

  1. #1
    The Timelord
    QDB Manager
    ZC Developer
    ZoriaRPG's Avatar
    Join Date
    Oct 2006
    Location
    Prydon Academy
    Posts
    1,294
    Mentioned
    107 Post(s)
    Tagged
    1 Thread(s)
    vBActivity - Stats
    Points
    4,319
    Level
    20
    vBActivity - Bars
    Lv. Percent
    79.32%

    2.53 Fixes -> Master : Need a Period of Suspended Pushes

    The next two days are a major holiday for me, so I will wait until it ends before I delve into this, but I want to get all of the minor fixes that we put into 2.53, into master.

    In order to do this, i would like to see a suspension period of a few days for any other changes, so that I do not need to worry about the builds breaking, as the changes are scattered about. Most of them are to link.cpp, ffscroipt, guys.cpp, qst.cpp, zquest.cpp, and similar. I also intend to get the fonts in, and to get master up to the spec for 2.54 and above.

    I am also either going to need someone who can stand by and apply the pulls, or to flipping have merge access, so that i can do this quickly, and efficiently. There is quite a lot of small stuff to go over and patch, and I do not want it to drag on any longer than needed. I do not want master to get any more out of sync with 2.53 fixes and features.

    Can we all agree on this one?
    Last edited by ZoriaRPG; 09-26-2017 at 12:56 AM.

  2. #2
    OBEY GOVERNMENT GOD ZC Developer
    Gleeok's Avatar
    Join Date
    Apr 2007
    Posts
    4,779
    Mentioned
    256 Post(s)
    Tagged
    10 Thread(s)
    vBActivity - Stats
    Points
    12,661
    Level
    32
    vBActivity - Bars
    Lv. Percent
    94.34%
    Sounds fine to me. Besides minor things I'm not working on master right now. I can help you with that if you let me know the day.

    Just give a timeframe for @DarkDragon and @Grayswandir so they know exactly when.
    "Protocols of the Learned Elders of Zion" (British Royal Institute, 1906)
    "The International Jew: The World's Foremost Problem" Henry Ford
    "The Host and The Parasite How Israel's Fifth Column Consumed America." Greg Felton
    "Fundamental Laws: A Report of the 68th Convocation of the Rose Cross Order" 1916
    "War is a Racket" Major General Smedley Butler
    "The Secret Destiny of America" Manly P. Hall
    "A Strategy for Israel in the Nineteen Eighties" Oded Yinon (English Translation)
    The WWI Conspiracy: Part 1 - Part 2 - Part 3 "A New World Order"
    The War You Don't See
    Psywar

    The modern theory of the perpetuation of debt has drenched the earth with blood, and crushed its inhabitants under burdens ever accumulating. Thomas Jefferson
    It is well enough that the people of the nation do not understand our banking and monetary system for, if they did, I believe there would be a revolution before tomorrow morning. Henry Ford
    Man will ultimately be governed by God or by tyrants. Benjamin Franklin

    This post contains the official Gleeok seal of approval. Look for these and other posts in an area near you.

  3. #3
    Keese
    ZC Developer

    Join Date
    Jan 2007
    Age
    29
    Posts
    52
    Mentioned
    27 Post(s)
    Tagged
    1 Thread(s)
    vBActivity - Stats
    Points
    593
    Level
    8
    vBActivity - Bars
    Lv. Percent
    66.98%
    Sure thing, I'll hold off on pushing for a while.

  4. #4
    Administrator DarkDragon's Avatar
    Join Date
    Oct 2001
    Posts
    6,228
    Mentioned
    68 Post(s)
    Tagged
    0 Thread(s)
    vBActivity - Stats
    Points
    10,839
    Level
    30
    vBActivity - Bars
    Lv. Percent
    85.82%
    Sure. I'm traveling this week and won't be able to touch the code anyway.

    By the way you should look into git cherry-pick. In some (but not all) cases it can apply patches from one branch painlessly to another one.

  5. #5
    OBEY GOVERNMENT GOD ZC Developer
    Gleeok's Avatar
    Join Date
    Apr 2007
    Posts
    4,779
    Mentioned
    256 Post(s)
    Tagged
    10 Thread(s)
    vBActivity - Stats
    Points
    12,661
    Level
    32
    vBActivity - Bars
    Lv. Percent
    94.34%
    I gave you write access so you don't have to deal with all this patch nonsense.
    "Protocols of the Learned Elders of Zion" (British Royal Institute, 1906)
    "The International Jew: The World's Foremost Problem" Henry Ford
    "The Host and The Parasite How Israel's Fifth Column Consumed America." Greg Felton
    "Fundamental Laws: A Report of the 68th Convocation of the Rose Cross Order" 1916
    "War is a Racket" Major General Smedley Butler
    "The Secret Destiny of America" Manly P. Hall
    "A Strategy for Israel in the Nineteen Eighties" Oded Yinon (English Translation)
    The WWI Conspiracy: Part 1 - Part 2 - Part 3 "A New World Order"
    The War You Don't See
    Psywar

    The modern theory of the perpetuation of debt has drenched the earth with blood, and crushed its inhabitants under burdens ever accumulating. Thomas Jefferson
    It is well enough that the people of the nation do not understand our banking and monetary system for, if they did, I believe there would be a revolution before tomorrow morning. Henry Ford
    Man will ultimately be governed by God or by tyrants. Benjamin Franklin

    This post contains the official Gleeok seal of approval. Look for these and other posts in an area near you.

  6. #6
    The Timelord
    QDB Manager
    ZC Developer
    ZoriaRPG's Avatar
    Join Date
    Oct 2006
    Location
    Prydon Academy
    Posts
    1,294
    Mentioned
    107 Post(s)
    Tagged
    1 Thread(s)
    vBActivity - Stats
    Points
    4,319
    Level
    20
    vBActivity - Bars
    Lv. Percent
    79.32%
    Quote Originally Posted by Gleeok View Post
    I gave you write access so you don't have to deal with all this patch nonsense.

    Thank you kindly. That will help immensely, as I will be able to make and merge the patches without waiting on someone else, repeatedly. I may be able to get them done in a day or two, instead of a week now.

  7. #7
    The Timelord
    QDB Manager
    ZC Developer
    ZoriaRPG's Avatar
    Join Date
    Oct 2006
    Location
    Prydon Academy
    Posts
    1,294
    Mentioned
    107 Post(s)
    Tagged
    1 Thread(s)
    vBActivity - Stats
    Points
    4,319
    Level
    20
    vBActivity - Bars
    Lv. Percent
    79.32%
    Quote Originally Posted by DarkDragon View Post
    Sure. I'm traveling this week and won't be able to touch the code anyway.

    By the way you should look into git cherry-pick. In some (but not all) cases it can apply patches from one branch painlessly to another one.

    Everything is done, and merged in master now.

    Please note that it is not the cause of issue 144..

    I sort of suspect your itemdata, npcdata, and weapon abstraction there, as it is an issue loading some components of the save data, that appear to not exist. It only affects Release builds, so tracking it down is not going to be fun, and you may want to look at some binaries from me to find any issues that are MSVC--8 related.

  8. #8
    Administrator DarkDragon's Avatar
    Join Date
    Oct 2001
    Posts
    6,228
    Mentioned
    68 Post(s)
    Tagged
    0 Thread(s)
    vBActivity - Stats
    Points
    10,839
    Level
    30
    vBActivity - Bars
    Lv. Percent
    85.82%
    Ok, I'll take a look.

  9. #9
    Administrator DarkDragon's Avatar
    Join Date
    Oct 2001
    Posts
    6,228
    Mentioned
    68 Post(s)
    Tagged
    0 Thread(s)
    vBActivity - Stats
    Points
    10,839
    Level
    30
    vBActivity - Bars
    Lv. Percent
    85.82%
    Is there a specific quest that's crashing? Or the default/empty quest? I just tried and couldn't reproduce the crash.

  10. #10
    The Timelord
    QDB Manager
    ZC Developer
    ZoriaRPG's Avatar
    Join Date
    Oct 2006
    Location
    Prydon Academy
    Posts
    1,294
    Mentioned
    107 Post(s)
    Tagged
    1 Thread(s)
    vBActivity - Stats
    Points
    4,319
    Level
    20
    vBActivity - Bars
    Lv. Percent
    79.32%
    Quote Originally Posted by DarkDragon View Post
    Is there a specific quest that's crashing? Or the default/empty quest? I just tried and couldn't reproduce the crash.
    Trying to use a timed save from 2.50.x, produces a header error:

    Code:
    Decrypting...okay.
    Opening...okay.
    Invalid header string:  '-(N=7A+	
    L>N*~ANLon' (was expecting 'AG Zelda Classic Quest File
     ' or 'AG ZC Enhanced Quest File
       ')
    Reading Header...error.
    After that, I tried to make a quest using ZQuest (master) in debug mode, and use a timed save from that. It also produced the same header error.


    Thus, I was only able to try the default quest.


    Here is my binary output from when I last built the master repo:

    http://timelord.insomnia247.nl/zc/zc...5SEPT_2017.zip

    Please tell me if that crashes for you, as it certainly does, for me. This was built using CMake->MSVC9 with the following flags:
    Unity: No
    PCH: No

    For MSVC, incremental linking is off.

    I still need to test if using the allegro debug libs to compile release cures this, to rule out an issue with alleg44.dll, or the other lib files; there is something odd going on with the libs in general too, as we have a slew of new bugs that occur only after Beta 2, and Beta 3+ are built using your last build of the allegro libs.

    Anyway, as this only affects master, I find it very unlike;y that the libs are a culprit, but I may as well verify that.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
About us
Armageddon Games is a game development group founded in 1997. We are extremely passionate about our work and our inspirations are mostly drawn from games of the 8-bit and 16-bit era.
Social