Allegro pull requests

[Gleeok]

@Gleeok : Are you working on this? I've been waiting for an update from you.

Sorry, must of missed this (pun intended).

What DD said. Not sure. If you mean the AS scripting I am messing around different ideas of getting scripts to "inherit" from c++ code and whatnot - kind of off and on. If you mean the atomic fix then no.

[ZoriaRPG]

Sorry, must of missed this (pun intended).

What DD said. Not sure. If you mean the AS scripting I am messing around different ideas of getting scripts to "inherit" from c++ code and whatnot - kind of off and on. If you mean the atomic fix then no.

@Gleeok and @DarkDragon

I meant the atomic fix. Should I just go with std::atomic and roll with it? I want to try fixing the libs before I compile them again. One nice thing about 4.4.3, is that the main deps are included, so it seems that it is no longer mandatory to do all the extra build steps at this point. I just wish that I knew with certainty what was needed to fix this, as it seems that the two of you have very different ideas on what is needed, and how to proceed.

You both seemed ready to tackle it, so I was waiting to see the results. I am not going to hack ASM back in to the library for a variety of reasons. THe most important, being that it is likely going to cripple it in the future, and it would never be pulled into the main 4.4.3 repo.

My plate has been pretty full of late, with many work-related requirements placed on me shoulders. I want to fix the libs, and make the needed fixes to 2.53, and simply be done with it, so that I can get back to working on master, and interim stuff.

[Gleeok]

@Gleeok and @DarkDragon

I meant the atomic fix. Should I just go with std::atomic and roll with it? I want to try fixing the libs before I compile them again. One nice thing about 4.4.3, is that the main deps are included, so it seems that it is no longer mandatory to do all the extra build steps at this point. I just wish that I knew with certainty what was needed to fix this, as it seems that the two of you have very different ideas on what is needed, and how to proceed.

You both seemed ready to tackle it, so I was waiting to see the results. I am not going to hack ASM back in to the library for a variety of reasons. THe most important, being that it is likely going to cripple it in the future, and it would never be pulled into the main 4.4.3 repo.

My plate has been pretty full of late, with many work-related requirements placed on me shoulders. I want to fix the libs, and make the needed fixes to 2.53, and simply be done with it, so that I can get back to working on master, and interim stuff.

Only problem is std::atomic is c++.

Sure. Point me to the 4.4.3 files (I'm assuming you guys are wanting to upgrade to the elusive dot three now) in the ZC master repo that need fixing (unless it's just wwin.c) and I'll give it a shot.


[edit] I should of hit reply hours ago before I got distracted and made dinner, not after. ..hardly counts as being ninja'd... Oh well, whatever.

[DarkDragon]

What is "this"?

I've working on fixing the issues the Allegro folks pointed out (I didn't correctly apply the 4.2 patch to 4.4) and should be done later this evening.

[DarkDragon]

You both seemed ready to tackle it, so I was waiting to see the results.

Sure, I'll do it.

[DarkDragon]

I just pushed a fix here: https://github.com/ArmageddonGames/a...060943e157cfa3

[Gleeok]

I just pushed a fix here: https://github.com/ArmageddonGames/a...060943e157cfa3

Great. Maybe now we'll get a rainbow without the death crash.


Completely hypothetical question for you: Do you think this is more likely to manifest on newer computers because of increased core counts and more complex (read: stupid ms windows) kernel scheduling? ...Like, for example, might something similar to this affect crash occurrence in theory if it didn't interrupt or block as much:

	SetProcessAffinityMask(GetCurrentProcess(), 1);
	SetThreadAffinityMask(GetCurrentThread(), 1);

?

Just a random thought.

[DarkDragon]

Great. Maybe now we'll get a rainbow without the death crash.


Completely hypothetical question for you: Do you think this is more likely to manifest on newer computers because of increased core counts and more complex (read: stupid ms windows) kernel scheduling? ...Like, for example, might something similar to this affect crash occurrence in theory if it didn't interrupt or block as much:

    SetProcessAffinityMask(GetCurrentProcess(), 1);
    SetThreadAffinityMask(GetCurrentThread(), 1);

?

Just a random thought.

Could be. But if the keyboard thread doesn't run as often, that can also cause problems (slow response to keyboard input, missed keys, etc).

[Gleeok]

Could be. But if the keyboard thread doesn't run as often, that can also cause problems (slow response to keyboard input, missed keys, etc).

Oh no no no. I wasn't suggesting that as a fix (that would be stupid!), just contemplating why it works on old hardware and as the computers get newer the problems would get worse. ...yeah, I'm not so great with hardware. CPUs are just crazy complicated nowadays.



P.S. @ZoriaRPG : How's CMAKE working out for you so far?

[ZoriaRPG]

Oh no no no. I wasn't suggesting that as a fix (that would be stupid!), just contemplating why it works on old hardware and as the computers get newer the problems would get worse. ...yeah, I'm not so great with hardware. CPUs are just crazy complicated nowadays.



P.S. @ZoriaRPG : How's CMAKE working out for you so far?

Edit: I may have this sorted.

I managed to build 4.4.3, but it is spitting out loadpng.dll and jpgalleg.dll as separate files from alleg44.dll. I'm not sure how to fix that. Any clues would be helpful.

Are there linker options in MSVC to build this in a monolithic mode, or CMake flags to use? Egdar wasn't very optimistic, despite 4.4.2 building as a monolith before, and I believe 4.4.3 did, too.

The actual alleg44.dll is working, and seems somewhat faster ( 20 to 40% ) , but of course, PNG and JPEG loading are broken. I do not know how to force link these three.

Here's a crazy thought: upgrade your browser? Probably your computer is riddled via trojans if you haven't been keeping up with security updates...

Also, you don't need to do any branch selection on the GitHub site to download the code. Just git clone https://github.com/ArmageddonGames/allegro5.git and then on your computer (*not* your browser) switch to the 4.4-ZCfixes branch.

(1) Newer firefox builds run far slower, and less reliably. They are plain awful,a nd TBH, if I did not need some features that were not in 28.0, I would still be using that. I can count the number of websites that I visit on this machine on my fingers. The majority of the time, it is simple:

(2) On this system, those are AGN, Pure, DoctorWhoTV, Youtube, StackExchange, Pastebin, GutHub, SourceFoce, Twitch (streams only), and HitBox (broadcasting only); and now, allegro.cc. I rarely venture outside of this range, and I run NoAcript, with all scripts disabled by default. I only enable content that I can validate. I'm quite far from the typical Internet user. I also run ABP to prevent any unauthorised content that NS misses, and ABE to catch redirect exploits. These tools are vastly superior to anything that Firefox 4+ offers, and given that Firfox + tend to make this system unusably slow, there is no real reason to update, until some content that I need forces it

(3) I do not download binary files on this system, barring open source content that I can verify, or build; or libs from very trusted sources.

(4) In-browser security, is primarily in the form of exploit prevention. For the most part, the bloat added to newer browsers to make them prettier, or to tack on useless features, is pointless, and their exploits are generally avoided by careful control over the sites and the services that you use, and the content that you permit to run. As I permit nothing to run by default, it's unimportant.

(5) I use no 'social media' sites, I do not log into anything untrusted, and I generally keep my circle very small.
For other content, I VNC into a remote system, and use that.

I have most of the major cookie engines, data mining engines (such as Google's advert mining) and such set to loop back to 127.0.0.1; too.

When I must use a newer browser, I have a current install of Chrome, which runs terribly, uses 4x as much RAM, and has a terrible UI.