Link randomly moving in one direction uncontrollably

[ZoriaRPG]

I think that I've fixed this. The cause had to do with @Saffith 's changes to cheat refills.

I'm going to need to re-write a refill system that uses modifier keys, instead.

Here's the commit:

https://github.com/ArmageddonGames/Z...23ed738bcf49fb

Removing those two calls negated this issue, so, it's time to find a different solution for non-overlapping key bindings.

[Saffith]

Given that those functions do nothing but copy data between internal arrays, I can't imagine why they'd have any effect here.

Someone on PureZC just had this issue, and changing joystick_index fixed it, suggesting the problem was indeed some device (like an accelerometer) incorrectly being treated like a controller.

[ZoriaRPG]

Given that those functions do nothing but copy data between internal arrays, I can't imagine why they'd have any effect here.

Someone on PureZC just had this issue, and changing joystick_index fixed it, suggesting the problem was indeed some device (like an accelerometer) incorrectly being treated like a controller.

It's happened to me, and my system has no such device: I have a keyboard, mouse, and standard display. No other devices. None of my devices have any such fancy inputs.

I had it happen with my KB, and I'm pretty sure it happened on my XP system with only a KB. It may have happened to me when using an iBuffalo controller on my older machine, too. It also happened 100% reliably if you tapped ESC to pause the game, which is what called that part of syskeys() to the forefront of my quest to solve this--it is a prime delay factor for 2.53.0--and randomly happened based on other things. Removing them absolutely did fix it.

Russ and Moosh had problems with it constantly. Venrob had it intermittently. It most commonly occurred on Win10.

I patched it, and everything works flawlessly now. Allegro's polling is weird through, and I'm a bit tired (no pun intended, but, appropriate) of losing sleep on this one; so this fix, known to solve it, should be fine.

I doubt that this one, intermittent as it was; happening at random, had anything to do with what device you are mapping, especially when it's happening on systems where the user only has a keyboard mapped. Feel free to not believe me if you want.

I changed the cheat hotkeys to require Control+Shift, which should be fine.

I don't have a Linux build--nor a non-debug version of the Allegro 4.4.3 Linux library at present, but here's the Windows build:

2.53.0 Beta 19 (Win)

ChangeLog for 2.53.0 Beta 19

Require using Control+Shift modifier keys in conjunction with cheat hotkeys.

//Beta 18.2
Fixed input getting stuck as if buttons were being held down, when released.
( ZoriaRPG, 25th September, 2018 )
( credit also: Venrob for think-tank.)
( credit also: Russ for testing.)

//Beta 18.1
Fixed the Cheat Menu 'Max Bombs' so that it is possible to set
any value from 0 to 0xFFFF.
( ZoriaRPG, 25th September, 2018 )

//Betas 16, 17, 18
Minor touch-up on qrNOGANONINTRO
Should fix: Nayru's Love decorations do not die, and will eventually wrap the screen.
Should fix: Vires freeze when struck, without split-on-hit.
( ZoriaRPG, 24th September, 2018 )
Should fix: Lens costs rupees with infinite wallet.
Should fix: Diagonal left-down sprites on 8-way shots are mis-oriented.
Should fix: Hammer stars appear in wrong spot.
Should fix: Charged hammer doesn't strike pound blocks.
Should fix: Ganon Triforce holdup when Link is jumping.
Should fix: Ganon's ashes don't fall in sideview.
( ZoriaRPG, 23rd September, 2018 )