Spin Attack w/ Magic Cost Goes Haywire

[ZoriaRPG]

Reported by Evan over on Pure ages ago. I seem to recall filing it in the old bug boards, but now IDK.


If you apply a magic cost to the spin attack scroll, and Link runs out of MP during the charge animation, Link will swing the sword automatically, every frame.

That was the premise. Evan has videos of this, and IIRC, it's because we're skipping a check when reading if we can charge the spin attack in link.cpp.

I think I posted about this, here, last year between September and December, but it may have been either in the old bug boards, or OT; unless that was a PM to @Tamamo , but I'm old and senile, so I've forgotten.

Documented now. AFAIK this wasn't fixed, but perhaps @Saffith did it at some point?

Edit: I discussed it here...
http://armageddongames.net/showthrea...s&goto=newpost

[Saffith]

Fixed.

[Tamamo]

It was a PM to me, I do recall it. I empty my Inbox too often, I should go back to never emptying it unless it's full.

[ZoriaRPG]

@Saffith : Newly fixed, or fixed, from the past report?

[Saffith]

Newly so.

[ZoriaRPG]

Newly so.

I was pretty sure that the problem was a lack of evaluating checkmagiccost during the charge cycle. I tried to find the message that I sent to Tamamo, but I have no idea when that was...sometime before the source release, I believe, and AGN doesn't facilitate PM searches.

I think that I sent a code snippet of my suggested change then, but now it's buried in my old messages.

Was it pretty much just moving the charge check under a magic check?

[Saffith]

No. The problem was that it was continuing to check the magic cost even after it had been paid.