Printable View
@Gleeok @ZoriaRPG @DarkDragon (this was personally requested by Gleeok to post)
The evidence: https://youtu.be/K-gADu2m06E
What I know about it:
1. Only seems to affect quests that had their origins in pre-1.84 that were compiled in 1.84 (like New Quest and Demo Quest)
2. Items prevent you from moving on
3. Doesn't work on all items
4. Last version it worked properly was 2.50.0
5. Still a problem in Beta 9
Hope this helps
-James
@Nightmare
All backwards compatibility with 1.84 has been lost as you've probably guess. Which is why i pushed for splitting the code base before opensource into 2.5.x and 3.0 branches. And simply abandon backwards compatibility for version 3.0.
We cannot maintain backwards compatibility forever. And once we swap out allegro. 1.84 compatibility and may'be even more versions beyond that may as well be a lost cause imho. I'm torn when it comes to backwards compatibility.
Should we do it? Yes. Can we do it with our limited and fragmented knowledge and experience of the source code? Yeah that's a very difficult question to answer. And you might not like my answer.
I honestly do not know, if it's possible to bring support for such an old version back.
James, are you certain that none of these issues existed in 2.50.0?
If not, then it is obviously an issue related to some change since that time.
@ZoriaRPG : None of these issues existed in 2.50.0
I know it's 2h-something, but the LP I made shows that everything works in 2.50.0.
I can further research in 2.50.1 if you want. 2.50.2 doesn't work AFAIK, but I can double-check.
-James
-James
Is that the same version of the demo quest as this? I'm not seeing the problem with that quest in 2.50.3 RC1.
I notice that both of those are items in cellars under rooms that also had items. Seems like that's likely to be relevant.
Yeah, the newest old version rebuilds and New Quest 2003's original file work fine in 2.50.2. Resaving the code in the original format helped out a lot.Quote:
Originally Posted by Saffith
That might be the case, with dual items causing an issue. Still, it's been in many other quests and 1.90+ didn't have that problem, so I'm kinda befuddled.
BTW. big big thanks to the DOSBox team (@Rambly and @Tim ) for the extensive help on some of these issues too and helping getting pre-1.92 versions working functional again. Give them a shout-out for everything they did to help this (and validating 1.02 as playable again too!)
-James
More test cases:
James Quest (original) - 1.90 roots, released in 1.92 - works fine.
New Quest Rebuilt - 2.50.x quest - works fine
I'm trying to build a new quest in 1.84 and get it to work: No dice. Works in 1.84 but just converts horribly: Gleeok's looking into it.
Honestly, just suggest tabling this and work on it for 2.54, other things are more important to be fixed. They still play except for the new test in 2.50.2 fine.
-James
Quote:
Originally Posted by Nightmare
Please check to see if the old gamme build '2.50.3rc1' has these issues, so that I can narrow down when they were introduced.
I have the sources for 2.50.3rc1 (not the same as 2.53!, and 2.50.1, but not 2.50.2 or 2.50.0. The source for 1.8 may be perma-lost.
If I can ever get source packs for 1.02, 1.84, 1.90, 1.92, 2.10, 2.10.2, 2.50.0, and (pure, not revisional) 2.50.2, I may make branches for them, so that the code for each 'releadsed' build is available for comparison.
@ZoriaRPG
New Quest and Demo Quest play fine in 2.50.3 RC 1 in the tested areas.
The absolute new test quest is not working though.
-James
2.50.2: Works as expected, 1.84 and 1.92 test
2.50.3 RC 1: Works as expected, 1.84 and 1.92 test
2.53: Dual item room bug exists.
Test file in Discord.
-James
So is the bug completely fixed in the 2.50.3? Or are there still issues? If so could you please post a link to the test .qst?
I tried this quest in 2.53 b2 and b10. It works as expected in b2, but the bug occurs in b10.
It does appear to be related to there being items both on the screen and in a cellar. I found that if I avoid getting the boomerang, the heart container will still be there. If I leave the cellar without getting the heart container, get the boomerang, and go back in, the heart container vanishes. It only works one way; if I get the heart container first, the boomerang is still there.
After opening the quest in ZQuest 2.50 and saving it, the problem no longer occurs.
Should be fixed now.
... but I probably broke something else so I'll commit it after a few tests. :/