PDA

View Full Version : Select Enemy window looks bad



Asuna Yuuki Nagato
03-14-2024, 11:32 AM
Steps to recreate:


File->New
Click black enemies section of bottom-left screen panel; observe "Enemies" window appears
Double-click any "(None)"; 'Select Enemy' window appears
Observe left side of 'OK' button is coincident with left side of "Select Enemy" window
Observe 'Edit' button partially obscures "WScript" label


When opened via Quest->Enemies, these problems don't occur.

Asuna Yuuki Nagato
03-14-2024, 05:51 PM
The "WScript" string comes from the bottom of enelist_proc in zquest.cpp

Asuna Yuuki Nagato
03-14-2024, 05:57 PM
The x position of the 'OK' button is controlled by:



elist_dlg[3].x = 240;


in select_enemy in zquest.cpp

Asuna Yuuki Nagato
03-15-2024, 04:25 PM
Since "(None)" is not a real enemy, we could disable the Edit button for it as well.

Asuna Yuuki Nagato
03-29-2024, 09:55 PM
Buttons have been moved down so WScript is no longer obscured:

https://github.com/ZeldaClassic/ZeldaClassic/commit/a88b02d7bd89c5b6f670e4f49b8f3b876ebc13c0

OK button moved to the right so it's no longer coincident with the left-hand side of the window:

https://github.com/ZeldaClassic/ZeldaClassic/commit/5819bd2ef9f3d44cb578b6a23fd31d77fae628c3