PDA

View Full Version : Negative chances in Item Drop Set Data window, especially "Nothing Chance:"



Asuna Yuuki Nagato
02-20-2024, 01:48 AM
Steps to recreate:


Quest->Misc Data->Item Drop Sets
Select any of the 256 item drop sets
Click 'Edit'
Type a negative number in "Nothing Chance:" text box
Observe negative percentage appears in adjacent percentage label
Click 'OK'
Click 'Edit' again
Observe negative number has been replaced with 16-bit two's complement


The chance text boxes on the two tabs clamp the negative chances to zero after clicking OK, but still update the percentage label with negative percentages in the meantime.

Asuna Yuuki Nagato
03-02-2024, 11:38 PM
The "Nothing Chance:" string comes from the edititemdropset_dlg array in zquest.cpp

Asuna Yuuki Nagato
04-09-2024, 02:08 PM
Negative percentages no longer occlude the dropdown.