PDA

View Full Version : Refactoring of ffscript.*



ZoriaRPG
01-08-2017, 12:46 PM
One thing that would be very wise to do in this branch, if Gleeok did not already do it, is to make the ArrayH class (and the SH class in general) available globally. At present, they are all very much tied to ffscript.cpp, and there is no way of handling them externally. The way they are set up in the 2.50.x tree, is somewhat idiotic, and you can't call these functions from outside of ffscript.cpp. I will set this up if it isn't already done, but many values will need rearranging.

I would say that all the ffcscript vars and classes belong in ffscript.h, and that the ffscript functions should be moved into classes, or rather, into a new 'class ffscript'.

DarkDragon
01-08-2017, 03:06 PM
I've moved this to a new thread, since it is unrelated to setting up CMake build environments.

ZoriaRPG
01-08-2017, 04:31 PM
I've moved this to a new thread, since it is unrelated to setting up CMake build environments.

Fair enough. I seem to remember Gleeok already doing this, or something related to it. At the least, I recall something of this sort in the old master branch. I put it in that thread as it may have fallen in line with the list of refactoring associated to it, but it can live in its own topic right enough.

jeffythedragonslayer
01-27-2024, 10:22 AM
I would like to help with this refactor.