User Tag List

Page 2 of 2 FirstFirst 1 2
Results 11 to 16 of 16

Thread: Zelda Classic 2.53.0

  1. #11
    Is this the end?
    ZC Developer
    Saffith's Avatar
    Join Date
    Jan 2001
    Age
    34
    Posts
    3,326
    Mentioned
    149 Post(s)
    Tagged
    6 Thread(s)
    vBActivity - Stats
    Points
    5,955
    Level
    23
    vBActivity - Bars
    Lv. Percent
    89.68%
    Daily Activity
    0%
    Weekly Activity
    155.29%
    Monthly Activity
    37.51%
    Quote Originally Posted by ZoriaRPG View Post
    I'll look into the strings when I have a chance. That is a far more minor issue than the other more abundant problems.
    It's not a big issue in itself, but why did it happen? Were you bringing in changes from an out-of-sync repo? I only noticed that because it's obvious and it's easy to see why it happened. Who knows what else might have broken?

    OnExit should run when the game exits, via F6, Game->End(), or when Link dies. It does that now. It is OnExit, not OnWinGame. The purpose is to clean up global vars, bitmaps, and other things that you want to clear when the game ends by death, or by F6. I'm not sure when this broke, or when it was fixed, but it definitely did not work in 2.50.2, it might have in 2.50.1 or 2.50.0, and it does work in 2.50.3RC1 and 2.53.0.
    Oh, yeah, that makes sense. The issue with it not initializing global arrays after F6->Continue was a side effect of it not running scripts if Quit was nonzero. I hadn't thought about it, but obviously that would affect OnExit, too.
    [téknolŕiz]

    ffcscript.zh 1.1.1 - Updated 2014-08-19
    ghost.zh 2.8.1 - Updated 2016-09-16
    tango.zh 1.2.0 - Updated 2016-09-16

  2. #12
    Gibdo Tim's Avatar
    Join Date
    Apr 2004
    Age
    29
    Posts
    575
    Mentioned
    27 Post(s)
    Tagged
    8 Thread(s)
    vBActivity - Stats
    Points
    2,716
    Level
    16
    vBActivity - Bars
    Lv. Percent
    99.23%
    Daily Activity
    0%
    Weekly Activity
    13.76%
    Monthly Activity
    8.24%
    Just an FYI on what I needed to edit for it to run Fullscreen without fps issues and glitchy/color/seizures:

    vsync = 1
    frame_rest_suggest = 0
    1600x1200 resolution - This was selectable via ZLaunch.

    This is on a GeForce 1070 with a 4k TV with a standard 60hz refresh. Windows 10 Pro x64 all up to date.

    Vsyncing my high refresh monitor is a different story. <_<

  3. #13
    ZC Contirbutor ZoriaRPG's Avatar
    Join Date
    Oct 2006
    Location
    Prydon Academy
    Posts
    882
    Mentioned
    76 Post(s)
    Tagged
    1 Thread(s)
    vBActivity - Stats
    Points
    3,234
    Level
    18
    vBActivity - Bars
    Lv. Percent
    32.89%
    Daily Activity
    0%
    Weekly Activity
    64.02%
    Monthly Activity
    57.53%
    Quote Originally Posted by Saffith View Post
    It's not a big issue in itself, but why did it happen? Were you bringing in changes from an out-of-sync repo? I only noticed that because it's obvious and it's easy to see why it happened. Who knows what else might have broken?


    Oh, yeah, that makes sense. The issue with it not initializing global arrays after F6->Continue was a side effect of it not running scripts if Quit was nonzero. I hadn't thought about it, but obviously that would affect OnExit, too.

    Ah-ha. That may have been all that changed, then; because the user reports that I saw, that indicated that OnExit was broken, were all array-related. This makes more sense now.

    Again, this was not a change that I made. It occurred in 2.50.3RC1, so it is apparently linked to the array changes, and I had forgotten about those. I need to note them in the changelog.


    Featured Scripts & Headers: RPG.zh ( v. a0.97.1 ) ( RPG.zh Thread ) | Zelda 3 Thief's Town Treasure Chest Minigame (ffc) | Bobomb (enemy)
    ZScript & ZC-Related Pastebin | Quests and ZScript Repository | ZC Dev & Betas | Latest ZC 2.54 Beta | YouTube Channel
    All of the code that I create and publish here is free for use, modification and distribution under the GPL v2.0, or v3.0 where applicable..

  4. #14
    ZC Contirbutor ZoriaRPG's Avatar
    Join Date
    Oct 2006
    Location
    Prydon Academy
    Posts
    882
    Mentioned
    76 Post(s)
    Tagged
    1 Thread(s)
    vBActivity - Stats
    Points
    3,234
    Level
    18
    vBActivity - Bars
    Lv. Percent
    32.89%
    Daily Activity
    0%
    Weekly Activity
    64.02%
    Monthly Activity
    57.53%
    Quote Originally Posted by Tim View Post
    Just an FYI on what I needed to edit for it to run Fullscreen without fps issues and glitchy/color/seizures:

    vsync = 1
    frame_rest_suggest = 0
    1600x1200 resolution - This was selectable via ZLaunch.

    This is on a GeForce 1070 with a 4k TV with a standard 60hz refresh. Windows 10 Pro x64 all up to date.

    Vsyncing my high refresh monitor is a different story. <_<
    Thank you @Tim . I will see if I can document some of this stuff, in a FAQ at some point. ZLaunch needs to be updated, too.


    Featured Scripts & Headers: RPG.zh ( v. a0.97.1 ) ( RPG.zh Thread ) | Zelda 3 Thief's Town Treasure Chest Minigame (ffc) | Bobomb (enemy)
    ZScript & ZC-Related Pastebin | Quests and ZScript Repository | ZC Dev & Betas | Latest ZC 2.54 Beta | YouTube Channel
    All of the code that I create and publish here is free for use, modification and distribution under the GPL v2.0, or v3.0 where applicable..

  5. #15
    Administrator DarkDragon's Avatar
    Join Date
    Oct 2001
    Posts
    6,178
    Mentioned
    54 Post(s)
    Tagged
    0 Thread(s)
    vBActivity - Stats
    Points
    10,673
    Level
    30
    vBActivity - Bars
    Lv. Percent
    65.46%
    Daily Activity
    0%
    Weekly Activity
    103.7%
    Monthly Activity
    32.14%
    Regarding the version strings: my understanding is that Zoria merged in some changes from before the github repository was established and this is the cause of the reversible.

    Zoria, I assume that everything on your end is now configured so that your local copy is kept constantly in sync, and you can easily send small and frequent pull requests (including a fix for the issues Saffith identified)?

  6. #16
    Administrator DarkDragon's Avatar
    Join Date
    Oct 2001
    Posts
    6,178
    Mentioned
    54 Post(s)
    Tagged
    0 Thread(s)
    vBActivity - Stats
    Points
    10,673
    Level
    30
    vBActivity - Bars
    Lv. Percent
    65.46%
    Daily Activity
    0%
    Weekly Activity
    103.7%
    Monthly Activity
    32.14%
    It's not a big issue in itself, but why did it happen? Were you bringing in changes from an out-of-sync repo? I only noticed that because it's obvious and it's easy to see why it happened. Who knows what else might have broken?
    Is there an update on this? Zoria, if you think some unintended changes snuck into the last patch, I can roll it back, and we can merge in one change at a time, carefully reviewing each one.

Thread Information

Users Browsing this Thread

There are currently 1 users browsing this thread. (0 members and 1 guests)

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
About us
Armageddon Games is a game development group founded in 1997. We are extremely passionate about our work and our inspirations are mostly drawn from games of the 8-bit and 16-bit era.
Social